Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Crash: ISR not in IRAM when #254 #257

Merged
merged 7 commits into from
Jun 13, 2019
Merged

Fix Crash: ISR not in IRAM when #254 #257

merged 7 commits into from
Jun 13, 2019

Conversation

torntrousers
Copy link
Contributor

Fix for #254

@sbrl
Copy link

sbrl commented Jun 8, 2019

Yep, this works 🚀

@morganrallen morganrallen merged commit ea34581 into sandeepmistry:master Jun 13, 2019
@sbrl
Copy link

sbrl commented Jun 13, 2019

🎉

@torntrousers
Copy link
Contributor Author

FYI, see the comment here. I did wonder about all the code thats in handleDio0Rise. The update in this PR does seem ok to fix the immediate 'ISR not in IRAM' crash but the approach to how the DIO interrupt is handled should probably be revisited.

mchacher
mchacher reviewed Jun 20, 2019
View reviewed changes
Copy link

@mchacher mchacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree on the principle but all handleDioRise method should be in IRAM as well as per variables used in the ISR

@marcelstoer marcelstoer mentioned this pull request Jun 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchacher mchacher mchacher left review comments

@sbrl sbrl sbrl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@torntrousers @sbrl @mchacher @morganrallen @antelder